Update 04/30/2011

Started by shmax, April 30, 2011, 12:46:03 PM

previous topic - next topic
Go Down

shmax

April 30, 2011, 12:46:03 PM Last Edit: December 31, 1969, 04:00:00 PM by Guest
- New "breadcrumbs"-style category navigation widget. You can see it in action when selecting a "Toyline" on any modify product page
- Revamped the mechanic for flagging parts as being "figure", "accessory", or "merchandise". Now you can select any combination of those properties, and I've also added a new one, "gestalt"
- fix formatting issues for part checklist in collection interface

Wajo357

#1
May 01, 2011, 04:42:06 AM Last Edit: December 31, 1969, 04:00:00 PM by Guest
getting php errors for each listing here: http://shmax.com/database/2451?r=0&sort ... 8ac0cdbc04

not sure if it is related.

I'm logged in on Opera...
<a href="http://www.shmax.com/img/sigs/signature.swf?user_id=853" target="_blank" class="new_win">http://www.shmax.com/img/sigs/signature.swf?user_id=853</a>

Tripredacus

#2
May 01, 2011, 08:22:36 AM Last Edit: December 31, 1969, 04:00:00 PM by Guest
Its a coding error:

Quote
[phpBB Debug] error particulars redacted
Which also leads me to recommend you sanitize your errors so that paths, filenames and the actual error and line number is not displayed on the website, instead logged somewhere only admins can see, and a generic response is displayed onto the page instead, such as "there was an error displaying this object" or something similar. "I AM ERROR" would be entertaining...  :mrgreen:

shmax

#3
May 01, 2011, 09:07:02 AM Last Edit: December 31, 1969, 04:00:00 PM by Guest
Bug fixed, sorry, guys. And yes, regular users should not be seeing error particulars. We had thought we'd sorted that out, but it seems there are still issues. Spaceharfang has been doing a lot of the error handling, so I'll leave it for him to figure out. Thanks, guys.

shmax

#4
May 01, 2011, 08:02:03 PM Last Edit: December 31, 1969, 04:00:00 PM by Guest
- fix both gif and Flash-based signatures. Something is still not working with Most Valuable toy computation... will look into it later if Spaceharfang doesn't get to it first

spaceharfang

#5
May 01, 2011, 08:50:25 PM Last Edit: December 31, 1969, 04:00:00 PM by Guest
Do you have an example of what is not working with the most valuable computation?

As for error management, I did some checking on my setup and it does work for the mentionned page.  When issues are encountered, I will need detailled accounting of when, where and how it did show inapropriately.  The full error message will help a lot too.

spaceharfang

#6
May 02, 2011, 07:49:51 PM Last Edit: December 31, 1969, 04:00:00 PM by Guest
Quote from: "shmax"
Just put some error in browse_skus.php, and watch what happens. For example:
Code Select

$tmp = $uninitialized[0];


The custom error handler provided by the forums gets invoked.
I tried it.  Works locally for me.   Standard users get the generic message.  Moderators get the full message.

spaceharfang

#7
May 02, 2011, 08:16:49 PM Last Edit: December 31, 1969, 04:00:00 PM by Guest
Quote from: "shmax"
Quote from: "spaceharfang"
Do you have an example of what is not working with the most valuable computation?
It's commented out right now. Just uncomment it and watch what happens.
You'll have to throw me a hint here.
I just can't seen to be able to find that commented code.

Wajo357

#8
May 04, 2011, 05:49:09 PM Last Edit: December 31, 1969, 04:00:00 PM by Guest
more php here: http://shmax.com/advanced_search?sort=d ... esults=100
look in box in the Part Type category
<a href="http://www.shmax.com/img/sigs/signature.swf?user_id=853" target="_blank" class="new_win">http://www.shmax.com/img/sigs/signature.swf?user_id=853</a>

shmax

#9
May 04, 2011, 08:38:53 PM Last Edit: December 31, 1969, 04:00:00 PM by Guest
Nice catch, thanks Wajo. Fixed. While I was at it, I made a few enhancements:
- part type filters now work on the product browsing page
- part type filters don't travel between the "PRODUCTS" and "PARTS" tabs

Go Up