[RESOLVED]Public link to Wishlist

[shesmovedon]

I've looked everywhere but I can't find a way, outside of the flash signature, to provide a public link to my wishlist. Is this possible? The URL I see when I look at my wishlist can't be used without an account and it must be used with my account as far as I can tell.

Thanks for an awesome site!

[shmax]

Egad, how long has it been like that?! This is definitely just an oversight, and I'll fix it tonight after work, fer sure. Thanks much for the catch--keep 'em coming.

[shmax]

Bah, who could wait? I've checked-in the fix. Thanks again...

[shesmovedon]

I was nervous I was just being obtuse. Just tried it out and it seems to work great. This saves me from having to type out my wants in a sale/trade thread on TFW. And I can give it to my woman if she's ever stumped on what to get me  :lol:

http://shmax.com/wishlist/1/1203

The page header says you're "editing anonymous's collection" but that's a minor cosmetic issue.

Thanks again for the awesome site

[shmax]

Fixed! Keep 'em coming...

[Tripredacus]

When I view the above link, it shows 30 items, but also shows no items.



EDIT: I am using Firefox 7.0.1 alas...
It works fine in IE9.  :roll:

[shmax]

Hah, me and my quick fixes, eh? Thanks, Trip, I'll fix it tonight...

[shmax]

Should be fixed, though I'm a little unsure of the changes I made. Spaceharfang, can you please look at revision #1598 and make sure I didn't screw anything up?

Thanks, guys...

[spaceharfang]

Checking...

[spaceharfang]

The WhishlistPage.class looks.
The SkuManager.class, I'll need some details on why you deactivated the code between line 166 and 191.  This code is meant to integrate "append info" data in the main query, thus reducing the number of rounds trips between php and mysql, improving processing speed.  When I did those changes, the gains were in the 20% range.  Eventually, the legacy appendinfo code will need to be removed to increase the compile time.

[shmax]

Lines 168 and 189 were adding in the id of the currently logged-in user, which is not what you want when viewing the public wishlist page for a given user. If you can figure out a way to refactor that stuff so that it all still works, then all the better. Let me know if I can help...

[spaceharfang]

I see.

When we view someone else wishlist, do we actually want those those values displayed?

[shmax]

You want them, but you wind up with two user_id's in the WHERE clauses, so you get no results. Try uncommenting them locally and visiting the wishlist page, you'll see what I mean.

[spaceharfang]

So we should see those values for the current user, not the visited user.