[RESOLVED]Shmax deleting dates bought?

Started by Wajo357, September 29, 2012, 05:24:43 PM

previous topic - next topic
Go Down

Wajo357

September 29, 2012, 05:24:43 PM Last Edit: October 06, 2012, 02:58:28 PM by shmax
I was updating shmax the other day and I noticed that when I was browsing some pages, some of my old items would auto-save, even thought they weren't touched. One example is http://shmax.com/product_details/6243/transformers_revenge_of_the_fallen_dvd_with_exclusive_black_optimus_prime. You can see the purple bar has the correct date, but when you expand it, it is not there. Hopefully I didn't loose a lot of data.
<a href="http://www.shmax.com/img/sigs/signature.swf?user_id=853" target="_blank" class="new_win">http://www.shmax.com/img/sigs/signature.swf?user_id=853</a>

engledogg

Not sure what's going on with the auto-saving bars, but since I can't see them (only you can), I checked your collection page.  It says you purchased Black Prime December 17, 2009...is that correct?

If so, the system seems to be storing it properly, but something may be up with the collection interface. 

I'm not seeing anything out of the ordinary myself, but I'm sure shmax will pop in soon and all will work itself out.  :)

MIKE
engledogg
Dumba$$ that used to buy everything...not so much anymore.

shmax

So the minimum allowed purchase date for this item is 12/18/2009. The date you put in there is for the 17th, which is one day before. There's some javascript code in there for this widget that attempts to validate input data, and it's blanking out your date because it's out of range.

I'm open to suggestions for how to fix this.

engledogg

I'd say for dates that pre-date the actual release date (and we know the release date to be absolutely correct), that the user will have to manually change the purchase date and input a valid purchase date,

OR

if they know that the release date in the system is incorrect, they could submit a change to the release date so that their purchase date is valid.

For example, let's say we have a toy in the system with a release date of 2/1/09 but a user can show that the toy was actually released on 1/31/09...either PM communication with a mod or a user-submitted change to the release date would take care of this invalid date business, right?

I really can't think of any other way to do it except on a case-by-case basis.

I suppose you could have the system auto-default the dates for stuff like this to the system's release date...I don't know...

MIKE
engledogg
Dumba$$ that used to buy everything...not so much anymore.

shmax

Engledogg and I talked this over a little more, and what we're going to do first is write some code that will find all collection records with "date bought" fields that predate their product's release date, and cap them at the release date. Then, I'll make sure this code gets called whenever a toy's release date is modified, and we should be good. Stay tuned for more info...

Wajo357

here are my thoughts:
I would think the easiest thing to do now is to just write an if statement that if the date is already stored, than it won't check the logic with the release date. This way it preserves the users data without corrupting it. My dates are 99% of the time the date I bought a figure. If I bought it before it was released, I use the shipping date. I use either of these 2 dates so if I ever have to, I can search my email for that date and should be able to trace back to an email of the purchase or shipment (for insurance or other reasons). Having shmax enter in another date (release date) without prompting the user would hurt me in this scenario.
<a href="http://www.shmax.com/img/sigs/signature.swf?user_id=853" target="_blank" class="new_win">http://www.shmax.com/img/sigs/signature.swf?user_id=853</a>

shmax

Good points. I'll talk it over with Ed some more...

shmax

Ed and I had another good long debate about this, and here's the new plan we came up with:

1. We will retain the existing restrictions on the "Add to my collection" link, such that it will be disabled until a toy has actually been released

2. Once a toy has been released, you are welcome to supply any "date bought" value that you like (though I suppose we should probably still not allow dates in the future)

3. On the "view collection" page, any items that have a "date bought" before the release date will display as "pre-ordered on <date>"

The main rationale for this is that we'll be able to use this data to help shape more informative graphs in the future once we finally start using collector data for the appraisal system.

Wajo357

sounds good to me...
<a href="http://www.shmax.com/img/sigs/signature.swf?user_id=853" target="_blank" class="new_win">http://www.shmax.com/img/sigs/signature.swf?user_id=853</a>

engledogg

I would also encourage users that can provide more accurate release dates to please do so.

MIKE
engledogg
Dumba$$ that used to buy everything...not so much anymore.

shmax

What he said. I plan to start on this tonight, folks. Sorry for the long delay, but I haven't been feeling well, and Borderlands 2 came out, the sun got in my eyes, etc, etc...

shmax

We should be all set. I've removed the restrictions on pre-release "date bought" values, and tweaked the front end to show "Pre-ordered" instead of "Purchased" on the view collection page. We'll try it like this for a while and see how it feels. Thanks, guys.

Tripredacus

It says "pre-ordered" even if no purchase date is entered.

shmax


Go Up