[RESOLVED]Item in collection not saving changes

[Tripredacus]

I have 2 Gobots Command Centers:
http://www.shmax.com/view_collection/2896/56

I have both added, the first one (opened) went fine but the second one (loose) I added won't save after I uncheck all the accessories. I've tried it multiple times, it always reverts to checking all the boxes again. I never see the "saving" thing come up, I've even let it sit there.

[shmax]

Fixed, maybe. I found a double-init in there somewhere, I fixed it, and now I can't repro. So, maybe. Please verify...

[Tripredacus]

It now does the saving transition, which it didn't do before... but it doesn't really save it. I tried it agian, it said "saving" and then went back to just saying "loose" (like normal), so I tested by navigating to the main category (Playsets) and expanded my loose item and all the boxes were checked again.

I also tried entering text into the comment. It saved that no problem.

So the checkboxes and drop down are not saved.

[shmax]

It now does the saving transition, which it didn't do before... but it doesn't really save it. I tried it agian, it said "saving" and then went back to just saying "loose" (like normal), so I tested by navigating to the main category (Playsets) and expanded my loose item and all the boxes were checked again.

I also tried entering text into the comment. It saved that no problem.

So the checkboxes and drop down are not saved.

Well, I did find one little bug, which I've fixed. How's it look now?

[Tripredacus]

Same thing!



But, I now have tried it in 2 browsers, Firefox and Palemoon. If it still isn't working maybe I can try it in Chrome tonight to see if it is a browser issue.

[Tripredacus]

Chrome makes no difference.

[shmax]

I dug around some more, and while I was still unable to repro the bug, I did notice that changes made to any select drop-downs (for missiles and whatnot) were not triggering the save response. I investigated a bit and discovered that the problem boils down to google closure's isArray function not working reliably. There was another one floating around online that doesn't work reliably, either, but I was able to tune it up so that it does. To add to the fun, I found yet another subtle issue having to do with the name attribute of said select drop-downs being set to garbage.

So, two more bugs fixed. Still broken for you?

[Tripredacus]

Still broken for you?

Yes.



But I'm not overly picky about it not saving. I only wanted to uncheck everything on both because I don't know what parts I actually have. So it isn't a big issue for me right now, but other users might have this problem if they add multiple items... I should look at some of my other multiple adds to see if they have the same behaviour. Maybe it is only a problem in the Gobots section?

I never added any Gobots into my collection before... because... I didn't know they were in the database before you split the toylines out. 

[engledogg]

Weird...I can confirm this happening (in Chrome) in other categories other than Gobots as well.

shmax, to repro, add a second anything to your collection (for example, if you have a Cybertron Leader Optimus Prime, add a second Leader Prime), choose any condition other than sealed for purchased condition, click some accessories to remove them, and click the blue bar.  Immediately after doing that, it appears okay...open the blue bar up, and you'll find things as you left them.

However, refresh the category/product page, click the blue bar again and you'll find the accessories you removed now have a checkmark by them - the removed accessories have been added back/not saved.

MIKE
engledogg

[engledogg]

Found something else related.  What Tripredacus explained above, and what I observed, only occurs with adding a multiple to your collection.  I observed the events above when adding a second Command Center to my collection.

However, something else seems to be going on if you're adding the first instance of a product to your collection.

Add something new to your collection, choose loose for purchased condition - the parts checklist remains frozen and is not editable.

Now remove it (click the remove link) since you can't do anything with it.

Now, add it again, but this time, choose loose for current condition - the parts checklist opens up and becomes editable.  So, click some boxes to remove them, click the blue bar again to save.

Now refresh the record/category.  The changes have been saved.

MIKE
engledogg

[shmax]

Ed explained about the second added collection item being the key to this, and I was able to figure out what's going on. Will take a little refactoring to fix properly, but I've gotta jet to work. Will have a fix tonight. Thanks, guys.

[Tripredacus]

Interesting you mention clicking the blue bar. I never tried that before to save. I usually just wait to see the saving "animation" occur before I leave the page.

[shmax]

Fixed! Thanks, guys.

[Tripredacus]

Yay!